Fix #4841: Load the compiler toolbox reflectively #4849
Conversation
|
Can you rebase this PR on top of #4833 to make sure that it works as expected with the stricter checks in that PR (or even better review and merge it :)). |
| catch { | ||
| case ex: ClassNotFoundException => | ||
| throw new ToolboxNotFoundException( | ||
| s"""Could not load the Toolbox class `${ex.getMessage}` in the classpath. Make sure that the compiler is on the classpath.""", |
There was a problem hiding this comment.
"in the classpath" -> "from the JVM classpath"
"on the classpath" -> "on the JVM classpath"
(To distinguish it from the compiler classpath)
There was a problem hiding this comment.
You should be able to move the {pos,neg}-with-compiler tests that only need the toolbox back to {pos,neg}. You should also be able to remove the exceptions when using -with-compiler with a non-bootstrapped compiler:https://github.com/lampepfl/dotty/blob/master/project/Build.scala#L610-L612 and https://github.com/lampepfl/dotty/blob/master/project/Build.scala#L679-L681
|
I got some unpickling issues when I moved the tests back. |
Can you investigate? It would be nice that the tests enforce that the compiler is not needed on the classpath |
No description provided.