Skip to content

Some refactoring #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

Some refactoring #4830

merged 1 commit into from
Jul 24, 2018

Conversation

allanrenucci
Copy link
Contributor

Some refactoring that I had hanging around locally

liufengyun
liufengyun approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 18fa15e into scala:master Jul 24, 2018
@liufengyun liufengyun deleted the cleanups branch July 24, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allanrenucci @liufengyun