Skip to content

Fix #4051: Add regression test #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2018
Merged

Fix #4051: Add regression test #4791

merged 1 commit into from
Jul 16, 2018

Conversation

allanrenucci
Copy link
Contributor

I am not entirely sure what fixed it to be honest. Maybe #4604

@smarter
Copy link
Member

smarter commented Jul 13, 2018

Wasn't it e42b83e ?

@allanrenucci
Copy link
Contributor Author

Wasn't it e42b83e ?

No. It seems that with this commit, you would just trade a NullPointerException for an AssertionError

Blaisorblade
Blaisorblade approved these changes Jul 15, 2018
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also maybe regression-test the unreduced testcase (Seq(("Porcupine", 1), ("Floyd", 2), ("Phil Collins", 3)).map(_._2)) for more bugs — I've seen patches fix minimizations but not the original testcases.

Otherwise LGTM.

@allanrenucci allanrenucci merged commit 292c51c into scala:master Jul 16, 2018
@allanrenucci allanrenucci deleted the fix-4051 branch July 16, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blaisorblade Blaisorblade Blaisorblade approved these changes

Assignees

@Blaisorblade Blaisorblade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allanrenucci @smarter @Blaisorblade