Introduce @forceInline annotation
#4755
Merged
+101
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Jul 4, 2018
|
On second thoughts, maybe we should keep this in the scala package like the inline annotation for now to avoid confusion. Eventually we'll remove this annotation anyway so it doesn't matter much. |
allanrenucci
changed the title
@annotation.forceInline annotation@forceInline annotation
| /** An annotation on methods that is equivalent to Dotty `inline` modifier. | ||
| * | ||
| * The annotation should be used instead of the `inline` modifier in code | ||
| * that needs to cross compile between Scala 2 and Dotty. |
There was a problem hiding this comment.
You should also mention that @forceInline will be ignored by Scala 2. Maybe hint at the need of @forceInline @inline for cross compilation with the optimization in both versions.
An annotation on methods that is equivalent to Dotty `inline` modifier. The annotation should be used instead of the `inline` modifier in code that needs to cross compile between Scala 2 and Dotty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An annotation on methods that is equivalent to Dotty
inlinemodifier.The annotation should be used instead of the
inlinemodifier in codethat needs to cross compile between Scala 2 and Dotty.
Fix #4737