Skip to content

Only allow access to inline args at level 1 #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

If it is needed at level 1 it can be explicitly lifted.
This simplifies the rules that users need to know and
the implementation of the phase.

@nicolasstucki nicolasstucki force-pushed the quote-macro-simplify-inline-args branch from 8b24a74 to 15b84fe Compare July 2, 2018 05:49
If it is needed at level 1 it can be explicitly lifted.
This simplifies the rules that users need to know and
the implementation of the phase.
@nicolasstucki nicolasstucki force-pushed the quote-macro-simplify-inline-args branch from 15b84fe to 48f1dfb Compare July 2, 2018 10:51
@Blaisorblade
Copy link
Contributor

That's the change we discussed time ago right? 👍 from me.

@nicolasstucki
Copy link
Contributor Author

Not exactly what we discussed, but it is related. I still want to do the one we discussed but it is a discussion for another PR.

@nicolasstucki nicolasstucki changed the title Only allow access to inline args at level 0 Only allow access to inline args at level 1 Jul 3, 2018
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand why the restriction was made?

Anyway, if it was made, the PMP document has to be updated accordingly. Not just change the wording, but motivate it and explain it there so that a reader can understand the restriction.

But I would prefer if we did not have to do it.

@odersky odersky assigned nicolasstucki and unassigned odersky Jul 6, 2018
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Jul 6, 2018

Thinking about it, the simplification I wanted to make only works for inline parameters, not for inline vals. Though this experiment showed me some vulnerability in the implementation of liftValue. I fix for that in #4777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants