Alt/instantiation checks (2) #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now prints `C{...}` instead of `$anon`.
The self type as given (or implied for module classes) in the source. Also defined and updated for normal types, not just ClassInfo types. Common functionality between this and baseTypeWithArgs has been pulled into RefinedType#wrapIfMember.
Check that the self type of a class conforms to the self types of its parent classes.
- Abstract classes cannot be instantiated (exceptions: parent news and Java annotations) - Instantiateed class must conform to its self type.
Java compilation units should not be retained after typer, as no code will be generated for them. All we need from them are their symbols.
An error message might be suppressed because it contains internal code. But if it is the first one, we should still print it. Otherwise, we risk a scenario where we see "2 errors" but none is printed.
We saw a failure of accessing a denotation outside its defined interval, which got triggered by i"...". This should never be the case. We should be more interested in what i"..." has to print. (V2, to see whether this builds with Travis now)
odersky
force-pushed
the
alt/instantiation-checks
branch
from
ee09bea to
35717b7
Compare
|
Travis failed with timeout before. I repushed the last commit with only the message edited to retrigger Travis (is there a better way to do so?) and now it passes. |
DarkDimius
added a commit
that referenced
this pull request
Apr 20, 2015
Alt/instantiation checks (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #471. Add a separate phase that checks that abstract classes are not instantiated and that self types conform.
This is probably easier to understand than #471 because the flow is concentrated in one tree traversal instead of being indirectly established by adding attachments to trees and looking at them.
Review by @DarkDimius