Harden IDE #4635
Harden IDE #4635
Conversation
I observed crashes when trying to compute the docstring of trees that did not have a position. It happened for edited code with lots of syntax errors.
| @@ -328,7 +328,9 @@ class DottyLanguageServer extends LanguageServer | |||
| if (sym == NoSymbol) Nil.asJava | |||
| else { | |||
| val refs = Interactive.namedTrees(uriTrees, Include.references | Include.overriding, sym) | |||
| refs.map(ref => new DocumentHighlight(range(ref.namePos), DocumentHighlightKind.Read)).asJava | |||
| ( for (ref <- refs if ref.namePos.exists) | |||
There was a problem hiding this comment.
I've hit on the same issue when doing syntax highlighting. The problem is that namePos is nonsensical for some special trees. For example trees named <init> or <error>. This probably doesn't fix the problem because you still get a position that exists but is wrong. I tried to fix it in #4548, but that's not the correct fix. namePos should probably return NoPosition for "synthetic" names. But I don't think we have such think as "synthetic" names.
There was a problem hiding this comment.
I think that this is going to fix the crashes, but it would obviously be better to fix the underlying issue: querying the position of these synthetic names.
@allanrenucci Do you have a reproducible way to reproduce that?
Yes, if you try to parse |
I observed crashes when trying to compute the docstring of trees that did not have a position.
It happened for edited code with lots of syntax errors.