Add Tasty compilation unit source file #4627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Jun 8, 2018
| def source: String = { | ||
| val thisPath = java.nio.file.Paths.get("").toAbsolutePath | ||
| val path = ctx.compilationUnit.source.file.jpath.toAbsolutePath | ||
| thisPath.relativize(path).toString |
There was a problem hiding this comment.
Some thoughts
- Not sure if consistent cross-platform behavior is a goal, but this will produce different paths in Windows and Linux/macOS. If you want normalized paths you can use
URI.normalize
thisPath.toUri.relativize(path.toUri).getPath- there are use-cases where you only care about the filename
source.getFileName.toString, in that case it's kind of annoying to have to parse the string to extract the filename - this relies on an implicit working directory
java.nio.file.Paths.get("").toAbsolutePath, what happens for example with virtual files?
There was a problem hiding this comment.
I was trying to relativize because our testing framework passes only absolute paths. I removed all this complication and just return the path as it was passed to the compiler.
nicolasstucki
force-pushed
the
add-tasty-ctx-file
branch
2 times, most recently
from
05215ab to
4fdb527
Compare
nicolasstucki
force-pushed
the
add-tasty-ctx-file
branch
from
4fdb527 to
837d38f
Compare
|
@nicolasstucki This PR broke master. Can you have a look? |
|
@allanrenucci there is already a fix in #4708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.