Fix synthetic type bounds in Tasty reflect #4601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
fix-synthetic-type-bounds
branch
2 times, most recently
from
bd4254b to
19a069c
Compare
nicolasstucki
force-pushed
the
fix-synthetic-type-bounds
branch
3 times, most recently
from
03403b4 to
3d3dbb6
Compare
To represent dotty TypeTrees containing type bounds
nicolasstucki
force-pushed
the
fix-synthetic-type-bounds
branch
from
8b5f22d to
a83f019
Compare
In dotty bootstapped the assert is inlined
nicolasstucki
force-pushed
the
fix-synthetic-type-bounds
branch
from
a83f019 to
420e4c5
Compare
liufengyun
approved these changes
Jun 13, 2018
| @@ -538,7 +538,7 @@ object TastyImpl extends scala.tasty.Tasty { | |||
|
|
|||
| object Synthetic extends SyntheticExtractor { | |||
| def unapply(x: TypeTree)(implicit ctx: Context): Boolean = x match { | |||
| case Trees.TypeTree() => true | |||
| case x @ Trees.TypeTree() => !x.tpe.isInstanceOf[Types.TypeBounds] | |||
| case _ => false | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Given the name synthetic, I cannot justify the change. Maybe a doc for Synthetic, I naively assume synthetic bounds are also synthetic.
There was a problem hiding this comment.
I will add some documentation.
| @@ -188,7 +190,8 @@ class ShowExtractors[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty | |||
| case Type.PolyType(argNames, argBounds, resType) => | |||
| this += "Type.PolyType(" ++= argNames += ", " ++= argBounds += ", " += resType += ")" | |||
| case Type.TypeLambda(argNames, argBounds, resType) => | |||
| this += "Type.TypeLambda(" ++= argNames += ", " ++= argBounds += ", " += resType += ")" | |||
| // resType is not printed to avoid cycles | |||
There was a problem hiding this comment.
I'm curious what kind of cycles can happen here?
There was a problem hiding this comment.
For definitions, we use the tree of the definition. Somewhere in the body of the type lambda there was a reference to itself and then tried to reprint itself in a loop.
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 23, 2018
…ounds Fix synthetic type bounds in Tasty reflect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.