Fix/overloaded access #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrap needs to produce alternatives with signatures. Otgerwise the new denotation will simply overwrite the old because both the overloaded TermRef and the alternative will hash to the same unique TermRef.
Overloaded TermRefs do not have an info, and consequently do not support =:=. Yet in Typer#checkNewOrShadowed we compared termrefs with =:=. This gives an exception if the termrefs are overloaded. The fix is to provide a new method isSameRef in TypeComparer which is called instead of =:= in Typer#checkNewOrShadowed.
| @@ -139,8 +138,7 @@ class Typer extends Namer with Applications with Implicits { | |||
| } | |||
| val where = if (ctx.owner.exists) s" from ${ctx.owner.enclosingClass}" else "" | |||
| val whyNot = new StringBuffer | |||
| val addendum = | |||
| alts foreach (_.isAccessibleFrom(pre, superAccess, whyNot)) | |||
| alts foreach (_.isAccessibleFrom(pre, superAccess, whyNot)) | |||
There was a problem hiding this comment.
So this is executed just for side-effects?
|
Yes, it's just for side effects. The allocation of a ListBuffer in the previous line hints to that. |
|
I repushed the branch after fixing merge errors. |
| @@ -245,7 +243,7 @@ class Typer extends Namer with Applications with Implicits { | |||
| * does properly shadow the new one from an outer context. | |||
| */ | |||
There was a problem hiding this comment.
I have trouble understanding how checkNewOrShadowed works. It seems there are two types: a "previously found result from an inner context", and a "new one from an outer context". One is called found, and the other is called previous, I guess. But which one is which? Both ways do not (yet ;-)) make sense for me...
|
Closing pull request and integrating in a new one. |
noti0na1
added a commit
to noti0na1/dotty
that referenced
this pull request
Dec 3, 2019
Disallow comparison between Object and Null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @DarkDimius @samuelgruetter
I apologize for the many commits. I have too much on my plate right now to spend time squashing them.