Add tasty Show type class and us in Tasty.XYZ.show #4577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For XYZ: Tree, TypeOrBoundTree, TypeOrBound and Constant
nicolasstucki
force-pushed
the
add-tasty-show
branch
from
cd3e0f0 to
b315dbf
Compare
liufengyun
approved these changes
May 25, 2018
| @@ -2,22 +2,19 @@ package scala.tasty.util | |||
|
|
|||
| import scala.tasty.Tasty | |||
|
|
|||
| class TastyPrinter[T <: Tasty with Singleton](val tasty: T) { | |||
| class ShowExtractors[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty0) { | |||
There was a problem hiding this comment.
I hope the name ShowExtractors can be improved later if possible.
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 25, 2018
Without this change, `showExtractors` is unstable and so is `showExtractors.tasty`, so `showExtractors.showTypeOrBounds`'s type gets approximated from `showExtractors.tasty.TypeOrBounds` to its bounds (`Any` or `Nothing` depending on variance), so the additions to the testcase fail. The same applies to other members. I also tried replacing `tasty.Tree` with `T#Tree` (and so on), but apparently those two types aren't considered equal, at least by Scalac (which is arguably a bug). Relates to code added in scala#4577.
| @@ -24,6 +25,15 @@ object TastyImpl extends scala.tasty.Tasty { | |||
| def toTasty(implicit ctx: Context): TypeTree = PickledQuotes.quotedTypeToTree(x) | |||
| } | |||
|
|
|||
| // ===== Show ===================================================== | |||
|
|
|||
| def defaultShow: Show[this.type] = showExtractors | |||
There was a problem hiding this comment.
Using def here makes the member unstable problems, see c9dbecc — I'm not using the API you used, but I'd expect both to work as they usually do.
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 26, 2018
Without this change, `showExtractors` is unstable and so is `showExtractors.tasty`, so `showExtractors.showTypeOrBounds`'s type gets approximated from `showExtractors.tasty.TypeOrBounds` to its bounds (`Any` or `Nothing` depending on variance), so the additions to the testcase fail. The same applies to other members. I also tried replacing `tasty.Tree` with `T#Tree` (and so on), but apparently those two types aren't considered equal, at least by Scalac (which is arguably a bug). Relates to code added in scala#4577.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For XYZ: Tree, TypeOrBoundTree, TypeOrBound and Constant