Do not allow running Expr that came as macro arguments #4576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is too hard to ensure that the contents of the tree can be pickled. It would be posible but the current ad-hoc solution is too brittle and has no good usecases.
biboudis
suggested changes
May 24, 2018
library/src/scala/quoted/Expr.scala
Outdated
| @@ -50,9 +50,8 @@ object Exprs { | |||
| * | |||
| * May contain references to code defined outside this Expr instance. | |||
| */ | |||
| final class TreeExpr[Tree](val tree: Tree, pickle: => Expr[_]) extends quoted.Expr[Any] { | |||
There was a problem hiding this comment.
Perhaps the comment need to be sync up that this refers to a Tasty Expr tree.
| case expr: TreeExpr[Tree] @unchecked => | ||
| new QuoteDriver().run(expr.pickled, runSettings) | ||
| case expr: TastyTreeExpr[Tree] @unchecked => | ||
| throw new scala.quoted.QuoteError("Can't run and scala.quoted.Expr coming from a macro argument") |
There was a problem hiding this comment.
The comment as is has a typo, so a fix can be "Cannot run a type scala.quoted.Expr" ...
However that error is thrown at the call site of an inline def. The f.run is invoked inside the macro body, so maybe we can rephrase into something the following maybe:
Cannot call an inline definition that runs an Expr that comes from a macro argument.
biboudis
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is too hard to ensure that the contents of the tree
can be pickled. It would be posible but the current ad-hoc
solution is too brittle and has no good usecases.