Document meaning of constant expressions #4527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/docs/reference/inline.md
Outdated
|
|
||
| Right-hand sides of inline values and of arguments for inline parameters | ||
| must be constant expressions in the sense defined by the [SLS § | ||
| 6.24](https://www.scala-lang.org/files/archive/spec/2.12/06-expressions.html#constant-expressions)), |
There was a problem hiding this comment.
You have one ) to many.
Clarification following scala#4431. The error checking's done by `Checking.checkInlineConformant(tree, isFinal = false, "argument to inline parameter")`, and `checkInlineConformant` uses `ConstantType` which characterizes constant expressions.
Blaisorblade
force-pushed
the
constant-expr-clarify
branch
from
98388f4 to
3039eca
Compare
|
Seems sufficient as a documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarification following #4431.
The error checking's done by
Checking.checkInlineConformant(tree, isFinal = false, "argument to inline parameter"), andcheckInlineConformantusesConstantTypewhich characterizes constant expressions.@TomasMikula opinions? (Since you asked what "constant expression" means).