WIP: Narrow typers error positions #4511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a followup to the earlier bugfix.
|
@Blaisorblade Can we get this in now please? We are blocked on a number of issues reporting stackoverflows until this in. |
smarter
reviewed
May 28, 2018
| @@ -16,7 +16,7 @@ object ErrorReporting { | |||
| import tpd._ | |||
|
|
|||
| def errorTree(tree: untpd.Tree, msg: => Message)(implicit ctx: Context): tpd.Tree = | |||
| tree withType errorType(msg, tree.pos) | |||
| tree withType errorType(msg, tree.pos.focus) | |||
There was a problem hiding this comment.
I'm not so sure anymore that this is a good idea, since it can lead to worse error messages
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 29, 2018
Intended to avoid the need for scala#4511.
|
Closing. The blocker is in fact #4385, which I just unblocked otherwise. |
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 29, 2018
Ensures stackoverflows aren't hidden by errors, without needing scala#4511. Also add relevant testcase from scala#4385 (comment); I confirmed this fails without the position fix.
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 30, 2018
Ensures stackoverflows aren't hidden by errors, without needing scala#4511. Also add relevant testcase from scala#4385 (comment); I confirmed this fails without the position fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @smarter. Gotta review and fix all the testcases. Needed to unblock #4385, which right now has too much potential to hide stack overflows.