Fix #4454 '.' after Number literal is not highlighted #4484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 8, 2018
|
It looks like you accidentally changed the scala-backend submodule in your commit. |
|
Yes, I was looking at that too. I'm not sure what happened there. Should I just revert it or make a new PR? |
|
You can amend the commit and push-force. |
smarter
approved these changes
May 8, 2018
| else if (numberStart(n)) { | ||
| def isNumber(c: Char): Boolean = | ||
| c.isDigit || c == '\u0000' || (c == '.' && remaining.nonEmpty && remaining.head.isDigit) | ||
| appendWhile(n, isNumber , literal) |
There was a problem hiding this comment.
there's an extra space after isNumber that shouldn't be there
|
Thanks for the quick fix @Blaisorblade ! Is there some code formatter setting for the code base or how do you format the code usually (I haven't found anything about this)? |
|
There isn't anything automatic currently, just make sure the code you're writing looks like it fits with the code around it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.