FIx source of performance regression in #3961 #4480
Conversation
nicolasstucki
changed the title
|
test performance with #quotes please |
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
1 similar comment
|
performance test scheduled: 3 job(s) in queue, 1 running. |
nicolasstucki
changed the title
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (eb4d2c8) |
nicolasstucki
force-pushed
the
performance-regression-on-quotes
branch
from
6c41dfb to
0ee13ca
Compare
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
1 similar comment
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
nicolasstucki
force-pushed
the
performance-regression-on-quotes
branch
from
0d8a423 to
842c90f
Compare
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
nicolasstucki
force-pushed
the
performance-regression-on-quotes
branch
from
842c90f to
2df97c4
Compare
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
1 similar comment
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (474e79a) |
nicolasstucki
changed the title
|
test performance with #quotes please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
| case _ => None | ||
| } | ||
| } else None | ||
| tree match { |
There was a problem hiding this comment.
A minor issue: the object name SOrRawInterpolator doesn't strictly correspond to what is in the code.
There was a problem hiding this comment.
That is not logic I made, I did not choose that name. Do you want me to change it to something else?
There was a problem hiding this comment.
It used to reflect what was in the code. Not anymore. I would just inline this extractor in StringContextIntrinsic
There was a problem hiding this comment.
Before the change, it's. After the symbolic equality checks are removed, it wasn't. But as we are going to remove local optimisations, it's fine to keep it as it is now.
There was a problem hiding this comment.
@liufengyun This is not part of the local optimisations that will be removed. Scalac does something similar
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4480/ to see the changes. Benchmarks is based on merging with master (ecf95c1) |
No description provided.