Create simple syntax highlighting tests #4441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benkobalog Looks like we could use this instead of your proposed SyntaxHighlightingTests, what do you think? |
|
@smarter I think it's a good idea to use this simpler solution. I can modify my PR to use this method instead, after this is merged. |
|
@benkobalog I am merging this then |
benkobalog
added a commit
to benkobalog/dotty
that referenced
this pull request
May 3, 2018
Added comments to updateLastToken function Use syntax highlight tests proposed in pr scala#4441 instead of the file based solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative test suite to the one in #3987. I think we should rely on simple and small tests for syntax highlighting and not files.
The implementation is adapted from https://github.com/lihaoyi/Ammonite/blob/master/amm/repl/src/test/scala/ammonite/unit/HighlightTests.scala