Prevent position errors on Ident(nme.ERROR) #4432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Exception in thread "main" java.lang.AssertionError: assertion failed: position error: position not set for Ident(<error>) # 24 at dotty.DottyPredef$.assertFail(DottyPredef.scala:36) at dotty.tools.dotc.ast.Positioned.check$1(Positioned.scala:178) at dotty.tools.dotc.ast.Positioned.check$5$$anonfun$4(Positioned.scala:203) ```
This reverts commit 0f7b1b0 but keeps the testcase.
Blaisorblade
force-pushed
the
fix-positioned-error-ident-failure
branch
from
0f7b1b0 to
78afe8a
Compare
Blaisorblade
added
area:parser
area:positions
stat:needs review
and removed
stat:wip
labels
|
@smarter I hear you're one of the few experts on positions bugs? |
odersky
approved these changes
Jul 1, 2018
There was a problem hiding this comment.
I believe there is a special case because this is a Thicket. Normally an atPos of a parent node will set positions of Child nodes. But we never do the atPos on the Thicket since Thickets don't have position. So the fix looks good to me, even though it is not a beauty ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop-gap fix for
which comes up often on the unminimized @alexknvl errors.
This fix looks wrong, and I've seen the comment in
atPoson the logic I'm fighting against, but I don't yet understand the logic enough for a proper fix.