Fix tree traversal in ElimByName #4429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance with #fast please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
smarter
reviewed
May 1, 2018
| @@ -50,7 +50,11 @@ class ElimByName extends TransformByNameApply with InfoTransformer { | |||
| /** Map `tree` to `tree.apply()` is `ftree` was of ExprType and becomes now a function */ | |||
| private def applyIfFunction(tree: Tree, ftree: Tree)(implicit ctx: Context) = | |||
| if (isByNameRef(ftree)) | |||
| ctx.atPhase(next) { implicit ctx => tree.select(defn.Function0_apply).appliedToNone } | |||
| ctx.atPhase(next) { implicit ctx => | |||
| transformFollowing(tree) | |||
There was a problem hiding this comment.
The transformFollowing should be outside of the ctx.atPhase.
ElimByName prevented some trees to be traversed by the following phases in the group.
|
performance test scheduled: 1 job(s) in queue, 1 running. |
smarter
approved these changes
May 1, 2018
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4429/ to see the changes. Benchmarks is based on merging with master (f54e7aa) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElimByName prevented some trees to be traversed by the following phases
in the group.