Fix #4419: liftFun should also update method parameter types #4428
Conversation
liufengyun
changed the title
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4428/ to see the changes. Benchmarks is based on merging with master (f54e7aa) |
| @@ -46,7 +46,8 @@ abstract class Lifter { | |||
| if (noLift(expr)) expr | |||
| else { | |||
| val name = UniqueName.fresh(prefix) | |||
| var liftedType = fullyDefinedType(expr.tpe.widen, "lifted expression", expr.pos) | |||
| // don't instantiate here, as the type params could be further constrained, see tests/pos/pickleinf.scala | |||
There was a problem hiding this comment.
This is very likely to break things. Dotty does not have global type inference, once you create a val, its type cannot be further constrained. (In fact, I remember adding the fullyDefinedType call here to fix a problem, git blame should tell you more)
There was a problem hiding this comment.
After looking into it this might be OK because we're more careful about how we deal with signatures containing type variables in recent versions of Dotty, I've found one related issue for which I've opened a PR: #4593
There was a problem hiding this comment.
Thanks a lot for looking into it @smarter !
Fix #4419: liftFun should also update method parameter types