Refine dependency extraction: Ignore packages #4326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Zinc only ignores packages for class dependencies but not for used names. This PR also ignores packages for used names. Not sure it is safe |
|
@smarter What's your take on this? Should we add used name for packages like Zinc does? |
|
I guess you need to because of package objects? If you import something from a package, and if the package object changes, then that may affect you |
allanrenucci
force-pushed
the
dep-package
branch
from
5f12e6b to
c0acf61
Compare
|
I have added a test case that is failing whether or not we add used names for packages. The test also fails in Zinc (see sbt/zinc#530) |
We can ignore packages when collecting dependencies for incremental compilation. We make sure not to ignore dependencies on package object.
allanrenucci
force-pushed
the
dep-package
branch
from
c0acf61 to
19b6e8b
Compare
allanrenucci
force-pushed
the
dep-package
branch
from
19b6e8b to
d2ee745
Compare
smarter
approved these changes
Apr 19, 2018
| addUsedName(fromClass, mangledName(sym), UseScope.Default) | ||
| // packages have class symbol. Only record them as used names but bot dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can ignore packages when collecting dependencies for incremental
compilation. We make sure not to ignore dependencies on package object.