Fix #431: Options make 2 steps of decoding instead of one #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This correctly fixes #431 and an issue I was having with value classes and pattern matching, I'm not familiar with PatternMatcher.scala so I can't say anything about the code itself. |
|
Neither can I. Formally it looks OK to me. So I leave it to @DarkDimius to merge if he thinks we should. |
|
Let's merge it as @smarter relies on it. |
DarkDimius
added a commit
that referenced
this pull request
Mar 30, 2015
Fix #431: Options make 2 steps of decoding instead of one
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 17, 2015
Idents of lifted symbols become class members, need to carry the right reference with the right prefix as type.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.