use ApproximatingTypeMap to simplify exhaustivity check code #4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
refactor-space-check
branch
from
61d4149 to
e5b18eb
Compare
smarter
approved these changes
Apr 13, 2018
| if (maximize) lo else hi | ||
| // expose type param references to their bounds according to variance | ||
| class AbstractTypeMap(maximize: Boolean)(implicit ctx: Context) extends ApproximatingTypeMap { | ||
| variance = if (maximize) 1 else -1 | ||
|
|
||
| def apply(tp: Type): Type = tp match { | ||
| case tp: TypeRef if tp.underlying.isInstanceOf[TypeBounds] => |
There was a problem hiding this comment.
While you're at it, maybe replace this by tp.symbol.isTypeParam
There was a problem hiding this comment.
@allanrenucci : tp.symbol.isTypeParam will miss the case where the reference is a type member.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 17, 2018
1. ApproximatingTypeMap produces Nothing, which is not what is needed. 2. Avoid blind erasure which lose information about the pattern, see tests/patmat/i4314b.scala
gsps
pushed a commit
to gsps/dotty
that referenced
this pull request
Apr 21, 2018
1. ApproximatingTypeMap produces Nothing, which is not what is needed. 2. Avoid blind erasure which lose information about the pattern, see tests/patmat/i4314b.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use ApproximatingTypeMap to simplify exhaustivity check code