Skip to content

WIP Relax realizability for erased members, treat them like lazy ones #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

WIP Relax realizability for erased members, treat them like lazy ones #4290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8a00db1
Clean up logic for isStable
odersky Mar 17, 2018
99ab436
Fix #4031: Check arguments of dependent methods for realizability
odersky Mar 17, 2018
d862da7
Fix typo
Blaisorblade Mar 19, 2018
7d0fd02
Special case comparison with Any
odersky Mar 20, 2018
d95554b
Align isRealizable with isStable
odersky Mar 20, 2018
ceaecda
Harden RefChecks
odersky Mar 28, 2018
3396862
Refactor realizability to also cache result of isStableRealizable
Blaisorblade Apr 5, 2018
9e56db8
Clarify documentation
Blaisorblade Apr 10, 2018
4753947
Seal Realizability
Blaisorblade Apr 10, 2018
b62f6db
Cache stability of non-lazy stable symbols
Blaisorblade Apr 10, 2018
7c8dc6e
Add stress-test for realixability checking
Blaisorblade Apr 10, 2018
bdfdc24
Rename SymDenotation.isStable to SymDenotation.isStableMember
Blaisorblade Apr 10, 2018
cccca68
Treat erased members like lazy ones
Blaisorblade Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/src/dotty/tools/dotc/core/Flags.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,10 @@ object Flags {
assert(AfterLoadFlags.isTermFlags && AfterLoadFlags.isTypeFlags)

/** A value that's unstable unless complemented with a Stable flag */
final val UnstableValue = Mutable | Method
final val UnstableValue =
Mutable | Method | Erased
// TODO: Erased should be treated as stable just like final lazy is.
// Otherwise the usefulness of Erased is very much reduced.

/** Flags that express the variance of a type parameter. */
final val VarianceFlags = Covariant | Contravariant
Expand Down
6 changes: 4 additions & 2 deletions compiler/src/dotty/tools/dotc/core/SymDenotations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,10 @@ object SymDenotations {
)

/** Is this a denotation of a stable term (or an arbitrary type)? */
final def isStable(implicit ctx: Context) =
isType || !is(Erased) && (is(Stable) || !(is(UnstableValue) || info.isInstanceOf[ExprType]))
final def isStable(implicit ctx: Context) = {
def isUnstableValue = is(UnstableValue) || info.isInstanceOf[ExprType]
isType || is(Stable) || !isUnstableValue
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be dropped after changes in #4759, achieves effects similar to cccca68.


/** Is this a "real" method? A real method is a method which is:
* - not an accessor
Expand Down