Evolving Tasty definitions #4286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to separate directory so that we can define other functionality around it.
| case DefaultGetter(methodName: TermName, idx: String) // s"$methodName${"$default$"}${idx+1}" | ||
| case Variant(underlying: TermName, covariant: Boolean) // s"${if (covariant) "+" else "-"}$underlying" | ||
| case SuperAccessor(underlying: TermName) // s"${"super$"}$underlying" | ||
| case ProtectedAccessor(underlying: TermName) // s"${"protected$"}$underlying" | ||
| case ProtectedSetter(underlying: TermName) // s"${"protected$set"}$underlying" | ||
| case ObjectClass(underlying: TermName) // s"$underlying${"$"}" | ||
|
|
||
| case Expanded(prefix: TermName, selector: String) // s"$prefix${"$$"}$name" , used only for symbols coming from Scala 2 | ||
| case ExpandedPrefix(prefix: TermName, selector: String) // s"$prefix${"$"}$name" , used only for symbols coming from Scala 2 |
There was a problem hiding this comment.
Why can we remove these ones?
There was a problem hiding this comment.
They are Scala2 interop only. I am not sure we need to expose these to macro writers. So I propose we just present the mangled names.
nicolasstucki
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to separate directory so that we can define other functionality around it.
There might be some more fixes as I try to write some code using these abstractions.