Fix #4272: make OrderingConstraint.&.mergeEntries symmetric #4276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would deal with this by rewriting the pattern match to match on (e1, e2) to handle all cases in one go |
Debugging revealed that in the failing testcase `e2: TypeBounds` while `e1: TypeRef`, and it's not clear why it should be otherwise.
|
@smarter What about now? Commits should now also make sense in isolation. |
smarter
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4272.
Debugging revealed that in the failing testcase
e2: TypeBoundswhilee1: TypeRef, and it's not clear why it should be otherwise.Other fixes are possible, this one is easy to maintain but will repeat a few
checks.