Fix #4217: display warnings in repl #4269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Apr 6, 2018
| @@ -235,6 +235,9 @@ class ReplDriver(settings: Array[String], | |||
| val newImports = newState.imports ++ extractImports(parsed.trees) | |||
| val newStateWithImports = newState.copy(imports = newImports) | |||
|
|
|||
| implicit val ctx: Context = newState.run.runContext | |||
There was a problem hiding this comment.
I don't think this implicit context is needed.
There was a problem hiding this comment.
You are right, an implicit State is required.
| @@ -235,6 +235,9 @@ class ReplDriver(settings: Array[String], | |||
| val newImports = newState.imports ++ extractImports(parsed.trees) | |||
| val newStateWithImports = newState.copy(imports = newImports) | |||
|
|
|||
| implicit val ctx: Context = newState.run.runContext | |||
| displayErrors(newState.run.runContext.flushBufferedMessages()) | |||
There was a problem hiding this comment.
Can you add a comment saying that this code displays warnings. Otherwise it confusing (the name of the function is misleading).
There was a problem hiding this comment.
Can that function get renamed a bit?
There was a problem hiding this comment.
Sure, it's for another PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4217: display warnings in repl