Unpickle quotes with the destination context #4242
Conversation
This avoids exponential traversal of the tree due to owner changes of the dummy valdefs for the contents of quote.
|
Alternative fix for issue tackled in #4238. This version does not need any owner change after unpickling. |
|
test performance please |
|
performance test scheduled: 113 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4242/ to see the changes. Benchmarks is based on merging with master (4c8a2bd) |
|
See last benchmark of http://dotty-bench.epfl.ch/4242/ |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully with some manual help (due to benchmark refactoring): Visit http://dotty-bench.epfl.ch/4242/ to see the changes. |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4242/ to see the changes. Benchmarks is based on merging with master (c8030ef) |
|
@smarter don't forget to review this PR |
| @@ -59,7 +59,10 @@ object PickledQuotes { | |||
| val unpickled = unpickle(tastyBytes, expr.args) | |||
| unpickled match { | |||
| case PackageDef(_, (vdef: ValDef) :: Nil) => | |||
| vdef.rhs.changeOwner(vdef.symbol, ctx.owner) | |||
| // vdef.rhs was unpickled with the current context. Symbols in vdef.rhs with | |||
| // owner vdef.symbol are unpickled as if their owner was ctx.owner. This optimization | |||
There was a problem hiding this comment.
Would be good to give the name of the method that does this in TreeUnpickler.
|
I will explore the possibility of pickling the tree directly in tasty. |
This avoids exponential traversal of the tree due to owner changes
of the dummy valdefs for the contents of quote.