Skip to content

New attempt to fix the leaking companion problem #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

New attempt to fix the leaking companion problem #424

wants to merge 1 commit into from

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 23, 2015

We now invalidate companions for all lifted symbols, whether they come from a tree or not.

Review by @DarkDimius

@odersky
New attempt to fix the leaking companion problem
4e0e48a 
We now invalidate for all lifted symbols, whether they come form a tree or not.
@odersky
Copy link
Contributor Author

odersky commented Mar 26, 2015

I hope this fixes #413.

@DarkDimius
Copy link
Contributor

The other way to fix #413 is to implement #353 that we've discussed on last meeting.
If implemented this will make a lot of logic in Flatten and RestoreScopes not needed anymore, I propose to wait and see if I'll succeed.

@odersky
Copy link
Contributor Author

odersky commented Mar 26, 2015

OK, makes sense.

@DarkDimius
Copy link
Contributor

closing in favor of #436

@DarkDimius DarkDimius closed this Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @DarkDimius