Fix of #39 #42
Fix of #39 #42
Conversation
Two fixes: 1) Avoid the infinite recursion in checkAccessible if the accessibility check fails. 2) Make accessibility succeed for the test, and in general if the target denotation does not have a symbol. Added original test in pos and a negative test which makes accessibility fail.
| @@ -40,6 +40,7 @@ class tests extends CompilerTest { | |||
| @Test def pos_overloaded() = compileFile(posDir, "overloaded") | |||
| @Test def pos_templateParents() = compileFile(posDir, "templateParents") | |||
| @Test def pos_structural() = compileFile(posDir, "structural") | |||
| @Test def pos_i39 = compileFile(posDir, "i39") | |||
There was a problem hiding this comment.
It would be good to have a http link for this issue on github, as "i39" is not so obvious.
There was a problem hiding this comment.
I think should have a naming convention for issue tests, then it will become obvious. Scala 2 has t123, should we do the same or stick with i123?
There was a problem hiding this comment.
Having such convention seems good idea.
I'd prefer i123.
|
Otherwise Ok for me |
|
LGTM |
|
Not sure if this is an issue: In object test241 {
trait A {
def foo(i: Int): String = ???
def foo(s: String): String = ???
}
class B extends A {
private def foo(s: String): String = ???
}
println((new B).foo(""))
}I get so the |
| val where = if (ctx.owner.exists) s" from ${ctx.owner.enclosingClass}" else "" | ||
| val whyNot = new StringBuffer | ||
| val addendum = | ||
| alts foreach (_.isAccessibleFrom(pre, superAccess, whyNot)) |
There was a problem hiding this comment.
why do you assign Unit to a val?
There was a problem hiding this comment.
Good catch. I will do a shortcut in the interest of time and fix it in the next commit.
Backport "Fix tupleTypeFromSeq for XXL tuples" to 3.3 LTS
Two fixes:
Added original test in pos and a negative test which makes accessibility fail.
Review by @DarkDimius, @samuelgruetter