Skip to content

Fix #4185: Do not check names for modules that will not be emitted #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

Fix #4185: Do not check names for modules that will not be emitted #4187

merged 1 commit into from
Mar 26, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki requested a review from biboudis March 26, 2018 12:35
@allanrenucci
Copy link
Contributor

I think a better and simpler solution would be to do the check when we generate the class file. At this point we only need to check if a class file was not emitted before
https://github.com/dotty-staging/dotty/blob/9aa2915b7bb251066bcc20209978b1d5851c15ca/compiler/src/dotty/tools/backend/jvm/GenBCode.scala#L419

odersky
odersky approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast!

@nicolasstucki nicolasstucki merged commit becf98a into scala:master Mar 26, 2018
@Blaisorblade Blaisorblade deleted the fix-#4185 branch March 26, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

@biboudis biboudis Awaiting requested review from biboudis

Assignees

@biboudis biboudis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasstucki @allanrenucci @odersky @biboudis