Enable -Ycheck:all #4183
Merged
Enable -Ycheck:all #4183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
changed the title
smarter
force-pushed
the
fix/Ycheck-frontend-2
branch
2 times, most recently
from
7869bc3 to
c5aca6e
Compare
smarter
force-pushed
the
fix/Ycheck-frontend-2
branch
from
c5aca6e to
7d703bb
Compare
odersky
approved these changes
Apr 16, 2018
| @@ -170,14 +170,15 @@ trait TreeInfo[T >: Untyped <: Type] { self: Trees.Instance[T] => | |||
| case _ => false | |||
| } | |||
|
|
|||
| /** Is this argument node of the form <expr> : _* ? | |||
| /** Is this argument node of the form <expr> : _*, or is it a reference to a | |||
| * such an argument ? The latter case can happen when an argument is lifted. | |||
This should be safe like skipping FunProto since we'll check the type application result anyway. This is needed to get -Ycheck:frontend to work when named type parameters are used like in t1513a.scala
Necessary for -Ycheck:frontend to work
It was accidentally disabled because elimJavaPackages was renamed.
This required a change to `isWildcardStarArg` to handle retyping repeated
arguments that have been lifted in Typer, for example:
foo(1, 2, 3)
might be lifted to:
val args: Int* = [1, 2, 3]
foo(args)
Needed to get tests/pos/infersingle.scala to pass -Ycheck:frontend
Necessary to get -Ycheck:pickler to pass.
smarter
force-pushed
the
fix/Ycheck-frontend-2
branch
from
7d703bb to
35c13d8
Compare
This was referenced Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.