Skip to content

Fix/restore scopes #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix/restore scopes #418

wants to merge 2 commits into from

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 19, 2015

Tentative fix to the "wrong owner" problems we are seeing in ClassfileParser. Review by @DarkDimius.

odersky added 2 commits March 19, 2015 22:46
@odersky
Disable tests that fail locally.
a8a0d4d 
Two tests do not work on my local setup: t3278 and dotc_parsing. a KeyNotFound Both die
with a KeyNotFound error in getPrimitive. t3278.scala contains a stacktrace.

I moved t3278 to disabled and added a failedOther option to dotc_parsing.
@odersky
Invalidate companions of classes lifted by FlatMap
c1eac25 
RestoreScopes enters classes lifted by FlatMap into the
enclosing package scope. It should also invalidate any companions
because otherwise we risk linking up a new class with a previously
generated companion which exists only as a Java classfile.
@DarkDimius
Copy link
Contributor

@odersky, I guess you have eclipse that uses an old version of scala-compiler fork, that causes KeyNotFound. I believe that's the bug that I have already fixed lampepfl/scala@f58d454

Can you please check? The version that should be currently used is
"me.d-d" % "scala-compiler" % "2.11.5-20150216-154453-f58d45491b"

@odersky
Copy link
Contributor Author

odersky commented Mar 20, 2015

That's probably it. How do I update to the new fork?

@DarkDimius
Copy link
Contributor

I'm not sure, as I use sbt to build the project.
If your project is imported from sbt, I guess you can reimport.
If you have it set up by hand: replace the scala-compiler that it depends on currently by https://oss.sonatype.org/content/repositories/releases/me/d-d/scala-compiler/2.11.5-20150216-154453-f58d45491b/scala-compiler-2.11.5-20150216-154453-f58d45491b.jar

@odersky
Copy link
Contributor Author

odersky commented Mar 21, 2015

Suoerseded by #420

@odersky odersky closed this Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @DarkDimius