Optimize findRef #4156
Merged
Optimize findRef #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by inlining two frequently used submethods
I noted this happening from tyoime to time in the IDE, and it is super annoying when it happens. Let's see if we can survive meaningfully after ignoring this condition.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
| @@ -549,7 +549,7 @@ class TypeErasure(isJava: Boolean, semiEraseVCs: Boolean, isConstructor: Boolean | |||
| if (inst.exists) sigName(inst) else tpnme.Uninstantiated | |||
| case tp: TypeProxy => | |||
| sigName(tp.underlying) | |||
| case _: ErrorType | WildcardType => | |||
| case _: ErrorType | WildcardType | NoType => | |||
| tpnme.WILDCARD | |||
| case tp: WildcardType => | |||
| sigName(tp.optBounds) | |||
There was a problem hiding this comment.
Does this code match twice against WildcardType? I don't get it. In fact, the latter matches appear to be erased away:
scala> def foo: Any => Any = { case _: String | Int => 1; case _: Int => 2 }
def foo: Any => Any
scala> foo(1)
val res0: Any = 2
scala> def foo: Any => Any = { case _: String | AnyRef => 1; case _: AnyRef => 2 }
def foo: Any => Any
scala> foo(new AnyRef())
val res1: Any = 2
There was a problem hiding this comment.
It first matches against the object WildcardType, then the case below matches against any instance of the class WildcardType.
There was a problem hiding this comment.
Yeah sorry, Allan explained me what's going on. But do we really know that the only instance of WildcardType(NoType) is the WildcardType object?
smarter
reviewed
Mar 22, 2018
| case _ => | ||
| go(tp.superType) | ||
| } | ||
| case tp: ThisType => // ??? inline |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4156/ to see the changes. Benchmarks is based on merging with master (0c5e39d) |
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
Mar 22, 2018
Triggered by my confusion on scala#4156.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by inlining two frequently used local methods