Various fixes for implicit/erased function types #4128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `typedDependent` we used to desugar the type `implicit (x: HasT) => x.T` to:
ImplicitFunction1[HasT, HasT#T] { def apply(x: HasT): x.T }
This commit sets the implicit/erased modifiers on all parameters of an
implicit/erased function type, this changes the desugaring to the more correct:
ImplicitFunction1[HasT, HasT#T] { def apply(implicit x: HasT): x.T }
smarter
force-pushed
the
fix/implicit-erased-funs
branch
2 times, most recently
from
6bd6bf5 to
303f6d2
Compare
smarter
force-pushed
the
fix/implicit-erased-funs
branch
from
303f6d2 to
a0f4afb
Compare
Previously, the implicit/erased flags were lost. The tag used for METHODtype was changed to make the encoding of the implicit/erased flags more convenient, this requires a major TASTY bump.
smarter
force-pushed
the
fix/implicit-erased-funs
branch
from
a0f4afb to
f66660a
Compare
odersky
reviewed
Mar 17, 2018
|
|
||
| // In binary: 101100EI | ||
| // I = implicit method type | ||
| // E = erased method type |
There was a problem hiding this comment.
Missing test case? I did not see a test where a refinement had implicit or erased parameters. In fact, I am not sure we even want to support this. If we don't support it, we won't need to complicate the TASTY format. Compared to the rest of the format, which is rather lean, this does stick out like a sore thumb.
There was a problem hiding this comment.
https://github.com/dotty-staging/dotty/blob/f66660a590cb488a4ea817dbcd0a5f8f49d68df9/tests/pos/implicit-dep.scala is a testcase for an implicit dependent function type, which ends up being desugared to a refinement with an implicit method
There was a problem hiding this comment.
I see. Seems we have to support this then!
odersky
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.