Fix owner of symbols created from TASTY LazyReaders #4115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LazyReader is completed using the current Context which may have a different owner than the one that was in place when the LazyReader was created, we compensate for this by explicitly recording and setting `Context#owner` when completing the LazyReader. Note: unpickling quotes used to rely on the previous behavior, we now use `changeOwner` instead.
smarter
force-pushed
the
fix/tasty-lazy-owner
branch
from
8167993 to
ff9e8b3
Compare
odersky
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A LazyReader is completed using the current Context which may have a
different owner than the one that was in place when the LazyReader was
created, we compensate for this by explicitly recording and setting
Context#ownerwhen completing the LazyReader.