add/strict #409
Merged
add/strict #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -strict option to do some type checks that are encessary to ensure type soundness, but are stricter than what Scala 2.x enforces. The first such test is the "pattern cannot be uniquely instantiated" problem where we reject a non-variant case subclass of a covariant superclass in a pattern match. The error is now only issued in -struct mode, otherwise it will be a warning. We might move more tests into the same category. This should help the transition.
| @@ -39,6 +39,7 @@ class ScalaSettings extends Settings.SettingGroup { | |||
| val defines = PrefixSetting("-Dproperty=value", "-D", "Pass -Dproperty=value directly to the runtime system.") | |||
| val toolcp = PathSetting("-toolcp", "Add to the runner classpath.", "") | |||
| val nobootcp = BooleanSetting("-nobootcp", "Do not use the boot classpath for the scala jars.") | |||
| val strict = BooleanSetting("-strict", "Use strict type rules, which means some formerly legal code does not typecheck anymore.") | |||
There was a problem hiding this comment.
Is there a document that describes what Scala code can be used with Dotty without any changes and what requires migration?
There was a problem hiding this comment.
Not yet. I think we should work one having one though.
|
Shouldn't we run the tests with -strict? |
|
Codewise LGTM, |
|
For the moment I would prioritize scala compatibility, also for the tests. Once we have everything under dotty we can selectively enforce -strict. |
DarkDimius
added a commit
that referenced
this pull request
Mar 13, 2015
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
May 27, 2025
Backport "Remove premature caching of lookups for unused lint" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -strict option to do some type checks that are encessary to ensure type soundness, but
are stricter than what Scala 2.x enforces.
The first such test is the "pattern cannot be uniquely instantiated" problem where we reject a
non-variant case subclass of a covariant superclass in a pattern match. The error is now only
issued in -struct mode, otherwise it will be a warning.
We might move more tests into the same category. This should help the transition. Review by @DarkDimius