Skip to content

Fix #4073: erase <repeted> type from lifted val for a vararg #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

Fix #4073: erase <repeted> type from lifted val for a vararg #4086

merged 1 commit into from
Mar 13, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki requested a review from smarter March 8, 2018 16:09
@nicolasstucki
Copy link
Contributor Author

@smarter now it takes into account java varargs. Though currently no test can be constructed for it.

smarter
smarter approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@smarter smarter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • typo in commit message: <repeted> -> <repeated>
  • Squash all commits together

Otherwise LGTM

@nicolasstucki
Copy link
Contributor Author

Squashed and fixed typo

@nicolasstucki nicolasstucki merged commit 37c2f93 into scala:master Mar 13, 2018
@allanrenucci allanrenucci deleted the fix-#4073 branch March 13, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @smarter