Don't force LazyRefs when computing isProvisional
#4082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw errors of recursive evaluation of LazyRefs in the IDE which were caused by the fact that `isProvisional` forced their computation. It should not do that. It now treats all uncompleted LazyRefs as provisional.
smarter
reviewed
Mar 8, 2018
| val uniqId = { | ||
| nextId = nextId + 1 | ||
| // // debug only: a unique identifier for a type | ||
| // val uniqId = { |
There was a problem hiding this comment.
It's a field in every type, and we don't need it - it's used nowhere.
smarter
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw errors of recursive evaluation of LazyRefs in the IDE which were caused by
the fact that
isProvisionalforced their computation. It should not do that.It now treats all uncompleted LazyRefs as provisional.