Fix trees not being loaded from tasty when class symbol has NoCompleter #4001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| denot.infoOrCompleter match { | ||
| case _: NoCompleter => | ||
| case _ => denot.ensureCompleted() | ||
| } |
There was a problem hiding this comment.
Why not simply denot.ensureCompleted()? I expect it to be NoOp if infoOrCompleter returns NoCompleter.
There was a problem hiding this comment.
Apparently I am wrong
There was a problem hiding this comment.
Will revert that change
nicolasstucki
force-pushed
the
fix-from-tasty-tree-loading
branch
from
1629d5b to
9f806bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.