Fix #3857: partial fix to generate more shallow tree in LabelDef #3994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Feb 13, 2018
| @@ -76,7 +76,12 @@ class LabelDefs extends MiniPhase { | |||
| case t: DefDef => | |||
| assert(t.symbol is Label) | |||
| EmptyTree | |||
| case _ => if (!labelDefs.isEmpty) super.transform(tree) else tree | |||
| case t: If => | |||
| val elsep2 = transform(t.elsep) | |||
There was a problem hiding this comment.
Can you add a comment explaining how this generate shallower trees?
nicolasstucki
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3857: partial fix to generate more shallow tree in LabelDef
The problem is not with the trees we generated in patmat, but the requirement for nest LabelDef before the calling site.