Skip to content

Restore caching of CachedMethodType #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented Jan 28, 2018

Looks like this was accidentally removed in
81dc91d

@smarter
Copy link
Member Author

smarter commented Jan 28, 2018

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

performance test failed:

Error line number: 24

[check /data/workspace/bench/logs/pull-3934-01-28-04.15.out for more information]

Looks like this was accidentally removed in
81dc91d
@allanrenucci allanrenucci force-pushed the fix/methodtype-caching branch from 402329a to 8cd5d33 Compare January 28, 2018 13:08
@allanrenucci
Copy link
Contributor

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

performance test failed:

Error line number: 24

[check /data/workspace/bench/logs/pull-3934-01-28-14.09.out for more information]

@smarter
Copy link
Member Author

smarter commented Jan 28, 2018

[check /data/workspace/bench/logs/pull-3934-01-28-14.09.out for more information]

@liufengyun Where can I find the logs for this failure?

@liufengyun
Copy link
Contributor

There is a stackoverflow testing Quotes: https://github.com/liufengyun/bench/blob/master/tests/power-macro/PowerInlined-1k.scala

I've disabled the test and now the test is running -- now per bench test takes about 2h.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3934/ to see the changes.

Benchmarks is based on merging with master (1793e86)

@smarter smarter requested a review from odersky January 28, 2018 19:18
@odersky
Copy link
Contributor

odersky commented Jan 29, 2018

Good catch.

@odersky
Copy link
Contributor

odersky commented Jan 29, 2018

Let's move the Quote test to pending for now, so that performance tests will work more reliably.

@smarter
Copy link
Member Author

smarter commented Jan 29, 2018

The version of this test we have in Dotty is currently disabled: https://github.com/lampepfl/dotty/blob/master/tests/pos/power-macro/PowerInlined-1k_2.scala

@smarter smarter merged commit 7862aaf into scala:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants