-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Restore caching of CachedMethodType #3934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test performance please |
performance test scheduled: 1 job(s) in queue, 0 running. |
performance test failed: Error line number: 24 [check /data/workspace/bench/logs/pull-3934-01-28-04.15.out for more information] |
Looks like this was accidentally removed in 81dc91d
402329a
to
8cd5d33
Compare
test performance please |
performance test scheduled: 1 job(s) in queue, 0 running. |
performance test failed: Error line number: 24 [check /data/workspace/bench/logs/pull-3934-01-28-14.09.out for more information] |
@liufengyun Where can I find the logs for this failure? |
There is a stackoverflow testing Quotes: https://github.com/liufengyun/bench/blob/master/tests/power-macro/PowerInlined-1k.scala I've disabled the test and now the test is running -- now per bench test takes about 2h. |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3934/ to see the changes. Benchmarks is based on merging with master (1793e86) |
Good catch. |
Let's move the Quote test to pending for now, so that performance tests will work more reliably. |
The version of this test we have in Dotty is currently disabled: https://github.com/lampepfl/dotty/blob/master/tests/pos/power-macro/PowerInlined-1k_2.scala |
Looks like this was accidentally removed in
81dc91d