Fix #533: Some isAbstractType tests should succeed for parameters #3931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also fixes #1747, using the same technique as scalac. |
|
Need to rebase because of #3892 |
…parameters Introduce a new test isAbstractOrParamType to capture this. Sicne we did not do this before, we missed out on the `Array[T] --> Array[T & Object]` transform for genereic Java arrays. The fix also needs an opposite fix to "undo" the parameter encoding again in arrayToRepeated.
This also fixes scala#1747 by allowing the same encoding as `scalac` to cope with overridden methods over unbounded generic arrays.
liufengyun
approved these changes
Jan 30, 2018
| final val DeferredOrTermParamOrAccessor = Deferred | TermParam | ParamAccessor | ||
|
|
||
| /** A deferred term member or a parameter accessor (these don't have right hand sides) */ | ||
| final val DeferredOrTypeParam = Deferred | TypeParam |
There was a problem hiding this comment.
The doc says Deferred term member or a parameter accessor, which is incorrect.
There was a problem hiding this comment.
OK, I'll roll that into a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new test isAbstractOrParamType to capture this. Sicne we did not do this
before, we missed out on the
Array[T] --> Array[T & Object]transform for genereicJava arrays.
The fix also needs an opposite fix to "undo" the parameter encoding again in arrayToRepeated.