Fix #1169: Fix strange type formatting in error message #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Jan 26, 2018
| @@ -56,7 +56,13 @@ class Bridges(root: ClassSymbol)(implicit ctx: Context) { | |||
| bridgesScope.lookupAll(member.name).exists(bridge => | |||
| bridgeTarget(bridge) == member && bridge.signature == other.signature) | |||
| def info(sym: Symbol)(implicit ctx: Context) = sym.info | |||
| def desc(sym: Symbol)= i"$sym${info(sym)(preErasureCtx)} in ${sym.owner}" | |||
| def desc(sym: Symbol)= { | |||
There was a problem hiding this comment.
Maybe:
val infoStr = sym.showDcl(preErasureCtx)
i"$infoStr in ${sym.owner}"This will print def produce: => X. But I think we could configure the printer to not print the =>. Other part of the compiler (such as error messages) could benefit from it.
There was a problem hiding this comment.
The problem is that printing the type will always print the =>. Otherwise it would be confusing. I would should work on the Printer but it has to look at the larger context to do the right thing.
|
Need to rebase because of #3892 |
We already generate an error message for i1169.scala, but it looked weird:
|bridge generated for member method produce=> X in class XProducer
|which overrides method produce=> T in trait Producer
|clashes with definition of the member itself; both have erased type (): Object.
The fix changes how ExprTypes in method signatures are handled. We now get:
|bridge generated for member method produce: X in class XProducer
|which overrides method produce: T in trait Producer
|clashes with definition of the member itself; both have erased type (): Object."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already generate an error message for i1169.scala, but it looked weird:
The fix changes how ExprTypes in method signatures are handled. We now get: