Skip to content

Fix #3886: add tests for dotc/dotr/dotd #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 26, 2018
Merged

Fix #3886: add tests for dotc/dotr/dotd #3892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
90a5ede
Fix #3886: add tests for dotc/dotr/dotd
liufengyun Jan 23, 2018
e32d238
address review: add `set -eux`
liufengyun Jan 23, 2018
a36f49d
add `set -eux` to sbtBootstrappedTests
liufengyun Jan 24, 2018
8388c4b
disable repl test on CI
liufengyun Jan 24, 2018
f8b059a
fix erroneous redundant quote
liufengyun Jan 24, 2018
3a45c04
remove another erroneous redundant quote
liufengyun Jan 24, 2018
9aeb1b9
merge sbtBootstrappedTests with cmdTests
liufengyun Jan 24, 2018
e7653fc
fix dir creation failure
liufengyun Jan 24, 2018
e7ef82d
fix mkdir with `-p`
liufengyun Jan 24, 2018
4d64987
remove redundant tests
liufengyun Jan 26, 2018
df14e43
add bin/dotd
liufengyun Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pipeline:
commands:
- cp -R . /tmp/1/ && cd /tmp/1/
- ./project/scripts/sbt ";compile ;test"
- ./project/scripts/sbtTests
- ./project/scripts/cmdTests

test_bootstrapped:
group: test
Expand Down
6 changes: 6 additions & 0 deletions project/scripts/sbtTests → project/scripts/cmdTests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,9 @@ else
echo "failed output check"
exit -1
fi

./project/scripts/sbt ";dist-bootstrapped/pack"
./dist-bootstrapped/target/pack/bin/dotc tests/run/hello.scala
./dist-bootstrapped/target/pack/bin/dotr Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the three lines above. Lines 82-83 already exercise this

echo ":quit" | ./dist-bootstrapped/target/pack/bin/dotr
mkdir -p _site && ./dist-bootstrapped/target/pack/bin/dotd -project Hello -siteroot _site tests/run/hello.scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add set -eux under #!/usr/bin/env bash otherwise the exit code of the script will be the result of the last command ran

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@allanrenucci allanrenucci Jan 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use ./bin/dotd instead

EDIT: Oups we don't have it. My bad. Maybe add an alias?