Fix #3876: Implement Expr.AsFunction #3880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Jan 21, 2018
| val x1 = SyntheticValDef(NameKinds.UniqueName.fresh("x".toTermName), x) | ||
| def x1Ref() = ref(x1.symbol) | ||
| def rec(f: Tree): Tree = f match { | ||
| case Block((ddef: DefDef) :: Nil, _: Closure) => |
There was a problem hiding this comment.
Use the closure extractor instead (in TreeInfo).
There was a problem hiding this comment.
closure only extracts the Closure and here we also need its DefDef. I will instead factor out a common extractor from closureBody and this me method.
odersky
approved these changes
Jan 22, 2018
| @@ -534,9 +534,18 @@ trait TypedTreeInfo extends TreeInfo[Type] { self: Trees.Instance[Type] => | |||
| } | |||
| } | |||
|
|
|||
| /** An extractor for closures with their def contained in a block. */ | |||
There was a problem hiding this comment.
I'd rename it to closureDef and return just the def. The closure part is used nowhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.