Fix #2760: Support defaults in Java annotations parsed from sources #3865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/java-default-annot
branch
2 times, most recently
from
56ec914 to
d00f754
Compare
odersky
reviewed
Jan 18, 2018
| @@ -0,0 +1 @@ | |||
| @Fork(value = 16) class Test | |||
There was a problem hiding this comment.
How do we know we get the right default in the backend? Can we make this a run test?
smarter
force-pushed
the
fix/java-default-annot
branch
from
d00f754 to
fb316ee
Compare
|
Hmm, the run test revealed another issue: Exception in thread "main" java.lang.NoSuchFieldError: value
at Test$.main(Test.scala:6)
at Test.main(Test.scala)Calling abstract class Fork(val value: Int = _root_.scala.Predef.???,
val warmups: Int = _root_.scala.Predef.???
) extends _root_.scala.annotation.Annotation with _root_.java.lang.annotation.
Annotation
with _root_.scala.annotation.ClassfileAnnotation {}and the |
It's defined in scala.annotation.internal, not scala.runtime
This commit is enough to get the added testcase to compile but not to run (it crashes with a NoSuchFieldError), this is fixed in the next commit.
Previously, for tests/run/i2760/Fork.java, the parser output was:
abstract class Fork(val value: Int = ???, val warmups: Int = ???)
extends ...
Since Fork is JavaDefined, calls to `value` were translated into
field calls, but `value` is a method, not a field, so i2760 crashed at
runtime with NoSuchFieldError. We now generate instead:
abstract class Fork private[this](x$1: _root_.scala.Unit)
extends ... {
def <init>(value: Int = ???, warmups: Int = ???)
def value(): Int = 1
def warmups(): Int = 1
}
This way we get both named parameters for the constructor and real
method calls.
smarter
force-pushed
the
fix/java-default-annot
branch
from
fb316ee to
a1a1a4b
Compare
|
Fixed by tweaking the parser output, see last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.