Add cyclic reference detection to TASTY unpickling #3842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
cyclic-unpickling
branch
from
96bf10b to
e023784
Compare
|
This makes it easier to find the root cause of issues like #3816: > run -Ythrough-tasty tests/pos/NoCyclicReference.scala
[info] Running dotty.tools.dotc.fromtasty.Debug -classpath /home/smarter/opt/dotty/library/target/scala-2.12/dotty-library_2.12-0.6.0-bin-SNAPSHOT-nonbootstrapped.jar tests/pos/NoCyclicReference.scala
Compiling from .scala sources
Compiling TASTY from .class sources
Exception in thread "main" java.lang.AssertionError: assertion failed: Cyclic reference while unpickling tree at address 61
... |
smarter
force-pushed
the
cyclic-unpickling
branch
from
e023784 to
c14aee6
Compare
smarter
force-pushed
the
cyclic-unpickling
branch
from
c14aee6 to
2bf3fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.