Fix #3478: Optimize away unused defs and lazy vals #3840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,6 +159,9 @@ class Devalify extends Optimisation { | |||
| if (replacements.contains(t.symbol)) | |||
| deepReplacer.transform(replacements(t.symbol)).ensureConforms(t.tpe.widen) | |||
| else t | |||
| case t: DefDef if timesUsed.getOrElse(t.symbol, 0) == 0 => | |||
There was a problem hiding this comment.
Does this remove only local definitions? Otherwise, it is not safe to remove public members and definitions
There was a problem hiding this comment.
Yes, the Simplifier only transforms local trees.
There was a problem hiding this comment.
But you are right. We still have inner classes. I will fix that.
nicolasstucki
force-pushed
the
fix-#3478
branch
from
0df75d7 to
d544507
Compare
OlivierBlanvillain
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.