Triage FromTasty tests #3837
Merged
Triage FromTasty tests #3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Jan 15, 2018
| /* assertion failed: owner discrepancy for type CC, expected: class <refinement>, found: class <refinement> | ||
| at scala.Predef$.assert(Predef.scala:219) | ||
| at dotty.tools.dotc.core.tasty.TreeUnpickler$TreeReader.symbolAtCurrent(TreeUnpickler.scala:195) | ||
| */ |
There was a problem hiding this comment.
What's the motivation for adding error message in the code?
There was a problem hiding this comment.
Easier to know which is the reason for the failure without rerunning all of them each time. We also had that in the stib blacklist.
There was a problem hiding this comment.
I think it would make more sense to open issues for each of them.
There was a problem hiding this comment.
I will work on minimizing them and open an issue with the minimized code. Then would refer to the group of tests that is likely to be failing because of that particular issue.
smarter
reviewed
Jan 15, 2018
| /* scala.MatchError: 136 (of class java.lang.Integer) | ||
| at dotty.tools.dotc.core.tasty.TreeUnpickler$TreeReader.readLengthType$1(TreeUnpickler.scala:231) | ||
| at dotty.tools.dotc.core.tasty.TreeUnpickler$TreeReader.readType(TreeUnpickler.scala:361) | ||
| */ |
nicolasstucki
force-pushed
the
from-tasty-triage
branch
from
e9b859e to
2bca60a
Compare
nicolasstucki
force-pushed
the
from-tasty-triage
branch
from
2bca60a to
9daaabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.